Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --enable-byterange or -DENABLE_BYTERANGE=true to compilation of C library for S3 data access #1264

Open
valeriupredoi opened this issue Jun 21, 2023 · 3 comments

Comments

@valeriupredoi
Copy link

Hey guys, quick question for you netCDF4pythoneers - will it be possible to add --enable-byterange or -DENABLE_BYTERANGE=true (for Cmake) to the compilation of C library so we can get S3 data access out the box, using an already built and bundled Python library, so we don't have to compile our own copy and store it in some barn, then point conda to it (the peasant's way)? Is there any red flag for this not to be used? Inspiration from the {netCDF-C docs](https://github.com/Unidata/netcdf-c/blob/main/docs/byterange.md). Very many thanks in advance, and cheers muchly for your awesome work! Also great to see GH friends like @ocefpaf around 🍺

@jswhit
Copy link
Collaborator

jswhit commented Jun 23, 2023

We don't handle the C library here - but this has been discussed for the libnetcdf conda package (see conda-forge/libnetcdf-feedstock#166 and conda-forge/libnetcdf-feedstock#160). Once that is available, we can build new wheels using the conda C libs using ocefpaf/netcdf4-win-wheels#6.

@valeriupredoi
Copy link
Author

@jswhit that's great, very many thanks, and my sincere apologies for missing your reply - not sure how I missed it, but in fairness, I was away last week. So it looks like my colleague and friend @zklaus has enabled byte-range in conda-forge/libnetcdf-feedstock#178 - does this mean you guys can now build new wheels? Cheers muchly 🍺

@valeriupredoi
Copy link
Author

hey guys, my apolos for pestering you, but do you guys have an estimate for when this will be included in a release? Many thanks in advance 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants