Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix errors with notebooks #102

Closed
wants to merge 1 commit into from
Closed

Conversation

kgoebber
Copy link
Contributor

@kgoebber kgoebber commented May 3, 2020

This PR fixes errors that were found as part of PR #100, mainly changes to web addresses and a couple of odds and ends. This will still fail on upperair_500_obs_contours.ipynb as it needs a function from MetPy 1.0 to work properly, but otherwise, this gets everything up to date.

The only major updates were to two notebooks that used GINI satellite data that was no longer available on the UCAR THREDDS. I changed them to use GOES-16/17.

Closes #101

@jthielen
Copy link
Contributor

jthielen commented May 4, 2020

Just to check, is the occasional removal of .metpy.parse_cf() related to Unidata/MetPy#1354 (comment), or some other issue?

@kgoebber
Copy link
Contributor Author

kgoebber commented May 4, 2020

No, I think those were just not needed as that parsing happens under the hood in the declarative syntax.

@dcamron
Copy link
Member

dcamron commented Aug 21, 2020

Closing in favor of #111. I did the work this week and came here to open the PR and was reminded that you had tackled a lot of this already, oops! Thanks for that work @kgoebber!

@dcamron dcamron closed this Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MNT: NCEI web addresses
3 participants