Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for spitting error out when pip fails #813

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

babyhuey
Copy link
Contributor

@babyhuey babyhuey commented Jan 4, 2024

This should help with this issue: #663

Currently, if pip fails, you just get a "Exited with code 1" that is entirely unhelpful and leads to people thinking they have other issues than dependency.

With this fix, it will spit out the error (if there is one)

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@babyhuey
Copy link
Contributor Author

babyhuey commented Feb 6, 2024

When do y'all think this will get merged/released?

@pgrzesik
Copy link
Contributor

@babyhuey - I'll try to release a new version in the coming days, thanks 🙇

@pgrzesik pgrzesik merged commit 787b479 into serverless:master Feb 10, 2024
2 checks passed
@babyhuey
Copy link
Contributor Author

@babyhuey - I'll try to release a new version in the coming days, thanks 🙇

Any update on getting a release out? It's really annoying for us to have to build locally when our pipelines fail with the wrong error

@pgrzesik
Copy link
Contributor

Hey @babyhuey 👋 Thanks for the ping and sorry for the delay here, the new v6.1.0 should be out now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants