fix: mixing runtimes and architectures #815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while running a setup where combining Python and NodeJS lambda's, I ran into a couple of issues:
dockerizePip
image would always default to provider.runtime / provider.architecturewhich would lead to the following error:
therefore I've adjusted
zipping to be to only be performed on either functions which runtimes are specifically python, or no runtime is set and
provider.runtime
is python3.to take function options as argument for retrieving the docker image.