Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dates, times, addresses, currency, numbers in v2 guidelines and English data #455

Open
nschneid opened this issue May 11, 2017 · 3 comments

Comments

@nschneid
Copy link
Contributor

nschneid commented May 11, 2017

Some observations:

  • Currency: A currency symbol should be related to a numeric amount via nummod (e.g. in "$ 40"), but in the English data it is sometimes compound.

  • Dates: flat includes examples of dates, but the English data has nummod (e.g., “March 28”)

  • Times: There is no apparent guideline for "10:00 pm" or "10 o'clock". In the English data, "a.m." and "p.m." are attached as nummod.

  • Addresses: It is not clear what the standard should be—flat?—for expressions like "100 Main St. NW Apt. 10".

  • Spelled-out numbers: flat gives the example "four thousand", but the English data has compound (e.g., these examples with "million")

@dan-zeman
Copy link
Member

We should discuss whether listing dates as an example of flat was a mistake or we really want to change the previous approach. We should also create a documentation page dedicated to dates. As a matter of fact, there has been a long discussion in #113 and especially in #210.

@jnivre jnivre added this to the v2.1 milestone May 28, 2017
@jnivre
Copy link
Contributor

jnivre commented May 28, 2017

Agreed. I have made this a v2.1 milestone.

@nschneid
Copy link
Contributor Author

From skimming #210, it seems that different syntactic constructions can become conventional ways to express dates. Perhaps the best solution would be not to force a uniform structure, but to subtype relations with :date to reflect their common function.

Thus, for English, something like:

Thursday, July 4, 1776
nummod:date(July, 4)
nmod:date(July, Thursday)
nummod:date(July, 1776)

Thursday, the 4th of July, 1776
det(4th, the)
nmod:date(4th, July)
case(July, of)
nmod:date(4th, Thursday)
nummod:date(4th, 1776)

While the head is "July" in the first case and "4th" in the second case, in both cases the 4 pieces of the date (weekday, month, date, year) are connected via relations with :date subtyping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants