Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlayerEx Compat/Support Request #52

Open
Dusty-Sprinkles opened this issue Apr 10, 2023 · 2 comments
Open

PlayerEx Compat/Support Request #52

Dusty-Sprinkles opened this issue Apr 10, 2023 · 2 comments
Labels
enhancement New feature or request mod compat

Comments

@Dusty-Sprinkles
Copy link

In packs where Icarus and PlayerEx are shared; the slowdown from armor applies to armor from playerEx's Strength stat, which I don't really think makes sense (as if you're stronger you should be able to fly harder to compensate)

Probably the best way to do this would be to only consider armor bonuses from equipped items/trinkets rather than the total armor value of a player

@CammiePone
Copy link
Member

That's not really an easy thing to do. There's one thing I can think of, but if a mod does armour differently from vanilla, it wouldn't work anymore

@UpcraftLP UpcraftLP added enhancement New feature or request mod compat labels Apr 13, 2024
@muon-rw
Copy link

muon-rw commented Apr 14, 2024

That's not really an easy thing to do. There's one thing I can think of, but if a mod does armour differently from vanilla, it wouldn't work anymore

I assume this means iterating over the armor value of each equipped armor slot instead of calculating total armor, which has worked well so far (not sure if could be a performance concern, but armor could just be recalculated less frequently)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mod compat
Projects
None yet
Development

No branches or pull requests

4 participants