Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of different heaps; use only binary sort #117

Open
mpadge opened this issue Oct 4, 2019 · 1 comment
Open

get rid of different heaps; use only binary sort #117

mpadge opened this issue Oct 4, 2019 · 1 comment
Labels
enhancement New feature or request simplification Opportunity to simplify code

Comments

@mpadge
Copy link
Member

mpadge commented Oct 4, 2019

Coz i'm pretty sure nobody uses them anyway, and the differences are very generally extremely minor. It was interesting to start with, but reducing to binary heap will simplify the code quite a bit, plus avoid using the shared_ptr between the heap types and so allow proper templating of types of heap variable. That will in turn make #90 more straightforward.

@mpadge
Copy link
Member Author

mpadge commented Jan 27, 2021

Reference #137, and the importance of templating both <int> and <double> for sorting, to take advantage of speed gains in the former case.

@mpadge mpadge added enhancement New feature or request simplification Opportunity to simplify code labels Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request simplification Opportunity to simplify code
Projects
None yet
Development

No branches or pull requests

1 participant