-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Affiliate Campaign Code URL causes EXC_BAD_ACCESS #23
Comments
Can you produce a sample project showing it in action? This isn't happening in the example project. |
I'll see if I can. The line was causing a crash in a live App. The reviewURL without the campaign code is fine, but I haven't had enough time to look through it completely yet. |
It is possible it may be happening inside UAAppReviewManager, but this is the first I have ever heard of the problem, so it may be something else acting awry here. We can see hundreds of other apps sending the default affiliate campaign codes so I suspect it may be the latter, but please do let me know if you see otherwise and we will patch it up. |
Actually, can you give us your app id and I will see if you have anybody sending it at all? It may not be a problem affecting all of your users, which would provide an extra data point. |
932468632 |
Good news is that we have no reports about that id yet, so whatever is causing the memory clobbering should be 100% reproducible. The attribute in question is strongly retained so there really should't be an issue within the framework itself. Check the integration you have, whether or not you have arc enabled or not, any other frameworks in your app which work with memory on a lower level. |
Cool, thanks. I'll keep looking into it. |
occurs on line #1017 in reviewURLString()
reviewURL = [reviewURL stringByReplacingOccurrencesOfString:@"AFFILIATE_CAMPAIGN_CODE" withString:[NSString stringWithFormat:@"%@", self.affiliateCampaignCode]];
self.affiliateCampaignCode is pointing to a junk memory address, despite being set properly prior to calling reviewURLString()
I was using your default values for Affiliate and Campaign codes.
The text was updated successfully, but these errors were encountered: