-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot read property 'name' of undefined when merge requried and not #159
Comments
@Fi1osof Thanks for reporting this, the intended behaviour in this case would be to throw an error alerting the user to conflicting types in the two files. Guessing this might have been missed for |
@cfnelson i think need not error alerting, just make result field required. |
@Fi1osof I think if there are any conflicts like the above example, they should be manually fixed, or a specific object is passed in as an option on how to resolve the multiple conflicting field type definitions into the specific type you specified. e.g -> Something like below could be passed into the mergeTypes function as an option to resolve your original example. It would instruction the mergeTypes on which type field definintion to resolve/merge. This is assuming someone doesn't wish to manually fix their graphql. const resolveConflicts = {
UserGroupUpdateInput: "String!"
}; |
@cfnelson graphql allow set notrequired variable as required. For example:
But can not like
So via merge schema have ability set notrequired field as required. |
Should be fixed by ardatan/graphql-toolkit#189 |
Fixed with |
Bug.
[email protected]
Merge two types:
(In first name not required, in second required).
Got error:
The text was updated successfully, but these errors were encountered: