Question: do directives on objects get merged?

[lastmjs]

I have a few schemas I'm merging together, and it doesn't seem to be merging in the following directive: directive @addId on OBJECT. Just wondering if it is known that object directives are not merged, or if I should do some more digging. Thanks!

[cfnelson]

@lastmjs Directives were introduced in this PR #144 and there is a known problem with them -> #156 which I believe should be a simple fix.

Not sure if this relates to your issue sorry. Would be curious to hear about anything you find!

[Fi1osof]

@lastmjs maybe fixed in #183

[cfnelson]

@lastmjs I believe the latest fix by Fi1osof may do this for you, you should test out v1.5.8 . Let us know if it works for you!!! If not you could create a PR to fix/support this.

[kamilkisiela]

Should be fixed by #196

[kamilkisiela]

It's available now under v1.6.0-beta.2. Let us know if it works :)

[essaji]

@kamilkisiela after upgrading to ^1.6.0-beta.2 now I am getting the following error when merging two schemas:

/node_modules/graphql-toolkit/dist/commonjs/epoxy/typedefs-mergers/directives.js:70
        throw new Error(`Unable to merge GraphQL directive "${node.name.value}". \nExisting directive:  \n\t${printedExistingNode} \nReceived directive: \n\t${printedNode}`);
        ^
Error: Unable to merge GraphQL directive "authorized". 
Existing directive:  
        directive @authorized(requires: [Roles] = [ADMIN]) on OBJECT | FIELD_DEFINITION 
Received directive: 
        directive @authorized(requires: String) on OBJECT | FIELD_DEFINITION

[kamilkisiela]

Yes because you can't merge them because they both have different arguments. Previously (before beta), merge-graphql-schema kept those two definitions which was invalid, there should be one definition per each entity.