Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websockets to return latest data (as opposed to every frame) #6

Open
beasteers opened this issue Jul 20, 2022 · 0 comments
Open

websockets to return latest data (as opposed to every frame) #6

beasteers opened this issue Jul 20, 2022 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@beasteers
Copy link
Contributor

I already made an initial effort on this, but it could use a second opinion and some testing to know if this is the best way to be doing this.

https://github.com/VIDA-NYU/ptg-api-server/blob/main/app/core/streams.py#L109-L176

Additionally, here's where it's used. I'm not totally convinced about this line latest = last_entry_id is None or '$' in last_entry_id so maybe it should be overridable by query parameter? idk

https://github.com/VIDA-NYU/ptg-api-server/blob/main/app/routers/data.py#L141-L153

@beasteers beasteers added enhancement New feature or request bug Something isn't working labels Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants