From 6722a249442a8316a13fd086f3b9e0439a8a1bdf Mon Sep 17 00:00:00 2001
From: Richardas Kuchinskas <r.kuchinskas@vk.team>
Date: Fri, 3 May 2024 16:04:42 +0300
Subject: [PATCH] added tests

---
 src/tests/checkers/php_aliases_test.go        | 43 +++++++++++++++++++
 .../golden/testdata/quickfix/phpAliases.php   |  9 ++++
 .../testdata/quickfix/phpAliases.php.fix      |  9 ++++
 .../quickfix/phpAliases.php.fix.expected      |  9 ++++
 4 files changed, 70 insertions(+)
 create mode 100644 src/tests/checkers/php_aliases_test.go
 create mode 100644 src/tests/golden/testdata/quickfix/phpAliases.php
 create mode 100644 src/tests/golden/testdata/quickfix/phpAliases.php.fix
 create mode 100644 src/tests/golden/testdata/quickfix/phpAliases.php.fix.expected

diff --git a/src/tests/checkers/php_aliases_test.go b/src/tests/checkers/php_aliases_test.go
new file mode 100644
index 00000000..6fba1a8b
--- /dev/null
+++ b/src/tests/checkers/php_aliases_test.go
@@ -0,0 +1,43 @@
+package checkers
+
+import (
+	"testing"
+
+	"github.com/VKCOM/noverify/src/linttest"
+)
+
+func TestPhpAliases(t *testing.T) {
+	test := linttest.NewSuite(t)
+	test.AddFile(`<?php
+declare(strict_types = "1")
+$_ = join("", []);
+`)
+	test.Expect = []string{
+		`Call to undefined function join`,
+		`Use implode instead of 'join'`,
+	}
+	test.RunAndMatch()
+}
+
+func TestPhpAliasesFunctionCall(t *testing.T) {
+	test := linttest.NewSuite(t)
+	test.AddFile(`<?php
+declare(strict_types = "1")
+$_ = join("", []);
+
+function test($d){
+ocicollmax();
+}
+
+test(join("", []));
+`)
+	test.Expect = []string{
+		`Use OCICollection::max instead of 'ocicollmax'`,
+		`Call to undefined function ocicollmax`,
+		`Use implode instead of 'join'`,
+		`Call to undefined function join`,
+		`Use implode instead of 'join'`,
+		`Call to undefined function join`,
+	}
+	test.RunAndMatch()
+}
diff --git a/src/tests/golden/testdata/quickfix/phpAliases.php b/src/tests/golden/testdata/quickfix/phpAliases.php
new file mode 100644
index 00000000..296b78c8
--- /dev/null
+++ b/src/tests/golden/testdata/quickfix/phpAliases.php
@@ -0,0 +1,9 @@
+<?php
+declare(strict_types = "1")
+$_ = join("", []);
+
+function test($d){
+ocicollmax();
+}
+
+test(join("", []));
diff --git a/src/tests/golden/testdata/quickfix/phpAliases.php.fix b/src/tests/golden/testdata/quickfix/phpAliases.php.fix
new file mode 100644
index 00000000..7f6babbc
--- /dev/null
+++ b/src/tests/golden/testdata/quickfix/phpAliases.php.fix
@@ -0,0 +1,9 @@
+<?php
+declare(strict_types = "1")
+$_ = implode("", []);
+
+function test($d){
+OCICollection::max();
+}
+
+test(implode("", []));
diff --git a/src/tests/golden/testdata/quickfix/phpAliases.php.fix.expected b/src/tests/golden/testdata/quickfix/phpAliases.php.fix.expected
new file mode 100644
index 00000000..7f6babbc
--- /dev/null
+++ b/src/tests/golden/testdata/quickfix/phpAliases.php.fix.expected
@@ -0,0 +1,9 @@
+<?php
+declare(strict_types = "1")
+$_ = implode("", []);
+
+function test($d){
+OCICollection::max();
+}
+
+test(implode("", []));