Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple HMD sample driver seems to be broken without any editing #1861

Open
BackTheBack opened this issue Jul 12, 2024 · 2 comments
Open

Simple HMD sample driver seems to be broken without any editing #1861

BackTheBack opened this issue Jul 12, 2024 · 2 comments

Comments

@BackTheBack
Copy link

Unzipping it and trying to build the driver in openvr-master\samples\drivers\drivers\simplehmd results in the error 'MyHMDDisplayComponent': cannot instantiate abstract class

this is without me making any edits to the code of the driver and this also happens on the version before the current release, I tested it and it was also broken on a virtual machine and I have not been able to fix it, likely due to my lack of skills using c++

all the other drivers compile without issue without editing any code in them

@Rectus
Copy link

Rectus commented Jul 13, 2024

Looks like the API was updated fairly recently, and the sample hasn't been updated to work with the new version. You likely need to implement MyHMDDisplayComponent::ComputeInverseDistortion() as it's specified in the header: https://github.com/ValveSoftware/openvr/blob/master/headers/openvr_driver.h#L2912

@danwillm
Copy link

danwillm commented Aug 9, 2024

Thanks - this should be fixed in the next SDK update.
As mentioned, the only change needed to get the sample building again is to implement MyHMDDisplayComponent::ComputeInverseDistortion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants