Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This repo and steam tarball are out of sync #2

Closed
kparal opened this issue Jan 18, 2019 · 6 comments
Closed

This repo and steam tarball are out of sync #2

kparal opened this issue Jan 18, 2019 · 6 comments

Comments

@kparal
Copy link

kparal commented Jan 18, 2019

The udev file in this repo doesn't reflect the udev file present in the official steam tarball:
http://repo.steampowered.com/steam/pool/steam/s/steam/steam_1.0.0.59.tar.gz

For example, this repo contains this rule:

# This rule is necessary for gamepad emulation; make sure you replace 'pgriffais' with a group that the user that runs Steam belongs to
KERNEL=="uinput", MODE="0660", GROUP="pgriffais", OPTIONS+="static_node=uinput"

while the tarball contains this rule (more modern):

# Steam Controller udev write access
KERNEL=="uinput", SUBSYSTEM=="misc", TAG+="uaccess"

There are more differences. Not only that, even the filenames differ (steam_input.rules vs 60-steam-input.rules and 60-steam-vr.rules).

This causes confusion for distributions, when deciding which udev files to install for the user. I assume this repo was created to have an opensource-friendly license for the udev file and allow PRs. Can you please make sure the files don't get out of sync? (Ideally, the latest content should be pushed here and then used for tarball generation, instead of having two sources). Thank you.

@TTimo
Copy link
Collaborator

TTimo commented Jan 18, 2019

Thanks. Yep I'll update with the latest steam package rules soon.

@kparal
Copy link
Author

kparal commented Jan 18, 2019

Thanks! When you're at it... 😉 this PR really needs to get merged to the udev file:
ValveSoftware/steam-for-linux#4794

I've been debugging why Steam Controller doesn't work on Fedora, and even pestering the Fedora maintainer of the package (rpmfusion/steam#10) and it really boils down to missing OPTIONS+="static_node=uinput". Without it, the uinput module is not loaded automatically and the user permissions are not applied. With a rule like this:

KERNEL=="uinput", SUBSYSTEM=="misc", TAG+="uaccess", OPTIONS+="static_node=uinput"

everything works out of the box (at least on Fedora).

@TTimo
Copy link
Collaborator

TTimo commented Jan 18, 2019

It's not clear if we can have one set of udev rules that will work on all distributions.

I think that was the original intention of this repository, to let distributions figure how they might want to modify this.

@kparal
Copy link
Author

kparal commented Jan 18, 2019

I see, distributions with systemd-udev won't support uaccess, IIUIC. Perhaps a readme file with some hints or clearly marked two different udev files here in repo could help.

@scaronni
Copy link
Contributor

It's not clear if we can have one set of udev rules that will work on all distributions.

I think that was the original intention of this repository, to let distributions figure how they might want to modify this.

Btw, the 60-steam-vr.rules already contain everything with uaccess directly, so I don't see the point of keeping the basic rule set with mode 666. Thanks.

@scaronni
Copy link
Contributor

Thanks. Yep I'll update with the latest steam package rules soon.

@TTimo any chance for the update matching the actual Steam tarball? I have a PR ready. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants