Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature Request - Support of Termux build on Android #163

Open
bonianchen opened this issue Jul 16, 2023 · 1 comment
Open

New Feature Request - Support of Termux build on Android #163

bonianchen opened this issue Jul 16, 2023 · 1 comment
Labels
wishlist Something that would be nice to have but not a priority

Comments

@bonianchen
Copy link

Termux (https://termux.dev/) nowaday fail to build vectorscan simply due to failure in hsbench part.
That (hsbench) part need one additional library (libandroid-shmem) to be included during the link stage.

This can be achieved simply by adding the library into CMakeLists.txt specific for hsbench itself. Vectorscan can be build pass in Termux and passed some local tests with this fix.

[Scope of work]

Branch: develop
File: tools/hsbench/CMakeLists.txt

Detail: Append following lines of text to the end of file:

if(CMAKE_SYSTEM_NAME STREQUAL "Android")
if (HAVE_SHMGET)
target_link_libraries(hsbench android-shmem)
endif ()
endif ()

@markos
Copy link

markos commented Aug 23, 2023

Android is not a supported platform, we cannot add it to our CI builds. if you can submit a PR that does not break other builds, we might include this in our builds, but you must understand that it's not a supported platform/architecture and there are no plans to add it to this list. It is possible that some other will break your Android builds in the future.

@markos markos added the wishlist Something that would be nice to have but not a priority label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wishlist Something that would be nice to have but not a priority
Projects
None yet
Development

No branches or pull requests

2 participants