Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

ng-change doesn't fire #19

Closed
juniorplenty opened this issue Apr 3, 2014 · 3 comments
Closed

ng-change doesn't fire #19

juniorplenty opened this issue Apr 3, 2014 · 3 comments
Labels
Milestone

Comments

@juniorplenty
Copy link

Using this code (less syntax):

slider(
  floor="0"
  ceiling="{{ placement.contracted_delivery }}"
  ng-model="flight.target"
  step="1"
  stretch="1"
  ng-change="allocate(flight)")

...the ng-change function never fires, it seems like it get sucked up by the directive.

@drgould
Copy link
Contributor

drgould commented Apr 4, 2014

There's might be a couple reasons for this:

  1. isolate scoping used by the slider
  2. non-standard use of ng-model by the slider

I'll take a look at this over the weekend.

@bertop89
Copy link

Found same issue the other day, tried to use a watch over the ng-model but was too slow.

@drgould drgould added this to the v0.3 milestone Apr 15, 2014
@drgould drgould added the bug label Apr 15, 2014
@drgould
Copy link
Contributor

drgould commented Apr 16, 2014

ngChange support has been added in v0.3.0. Happy sliding!

@drgould drgould closed this as completed Apr 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants