Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use logging module in client instead of print #2350

Open
houqp opened this issue May 27, 2021 · 1 comment
Open

use logging module in client instead of print #2350

houqp opened this issue May 27, 2021 · 1 comment
Assignees

Comments

@houqp
Copy link
Contributor

houqp commented May 27, 2021

Verta python client should use the builtin logging module to handle various info/debug/error logging needs. This way downstream application can have full control over stdout. Using print for logging in a library is generally an anti-pattern in python.

@convoliution
Copy link
Contributor

Thanks @houqp! It's on our radar to replace the print-based "logging" statements with proper logging invocation. I'll make sure to tag this Issue in the PR when it's in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants