Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting setMaxBinaryMessageBufferSize and other EndPointConfig for JSR356 WebSocket implementation #29

Open
ruzkant opened this issue Jan 11, 2020 · 0 comments · May be fixed by #30
Open

Support setting setMaxBinaryMessageBufferSize and other EndPointConfig for JSR356 WebSocket implementation #29

ruzkant opened this issue Jan 11, 2020 · 0 comments · May be fixed by #30

Comments

@ruzkant
Copy link

ruzkant commented Jan 11, 2020

Currently it sets a default of Integer.MAX_VALUE, and Tomcat allocates a BytBuffer of that size which can cause an OutOfMemoryError.

Also expose the EndPointConfig to subclasses to make it setMaxBinaryMessageBufferSize on that level.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix setMaxBinaryMessageBufferSize, provide JSR356 objects to subclasses ruzkant/gwt-rpc
1 participant
@ruzkant