Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] 1.7 animations #376

Open
7n7e7o7 opened this issue Mar 12, 2024 · 11 comments
Open

[Request] 1.7 animations #376

7n7e7o7 opened this issue Mar 12, 2024 · 11 comments
Labels
enhancement New feature or request

Comments

@7n7e7o7
Copy link

7n7e7o7 commented Mar 12, 2024

Problem Description

1.7 player animations and item animations to 1.20 (or whenever they changed).

Solution Description

animations can be found in the labymod 4.0 client for example.
So please add
1.7 player animations:
-Head Rotation
-Backwards
-Sneaking
-Blockbuild
-Heart
-Damage
-Hitbox

Alternatives

No response

Additional Info

No response

@7n7e7o7 7n7e7o7 added the enhancement New feature or request label Mar 12, 2024
@FlorianMichael
Copy link
Member

Sneaking is already implemented (there are multiple sneaking settings you should check out in Debug settings), I don't know about most animations you are mentioning here, it would be good if you could provide examples in form of short videos so we understand what you mean by e.g. "Backwards"?

@7n7e7o7
Copy link
Author

7n7e7o7 commented Apr 5, 2024

can I contact you somewhere else? discord for example

@FlorianMichael
Copy link
Member

Yes, florianmichael

@lowercasebtw
Copy link
Collaborator

17w13a - The player's body now entirely faces to the front, when moving backwards. Prior to this snapshot, moving backwards would cause the player model to rotate one side, making it look like the player was strafing backwards somewhat.

1.12 Snapshot ^

Prior to 1.12, the player walking backwards would be tilted sideways a bit

@FlorianMichael
Copy link
Member

Thanks for looking up the exact version, I'll see what I can do.

@FlorianMichael
Copy link
Member

77c3a00 - backwards animation is now implemented/fixed

@lowercasebtw
Copy link
Collaborator

Isn't sneaking already in par with 1.7?

Afaik, 1.8-1.12.2 broke the sneak animation

Then 1.13 fixed the smooth sneak animation which should be same as 1.7's

Then 1.14 just changed sneak height but the code is still the same, and viafab afaik alr changes the sneak height to be what it was 1.13 and below

So in turn, it should be identical to 1.7

Although, maybe its a speed difference, idk. It did feel off when playing vanilla 1.6.4 vs viafab 1.6.4 on 1.20

@lowercasebtw
Copy link
Collaborator

I do know in 1.7, there was a tilt to all items ingame, but idk how that would affect 1.20 stuff or packs

@FlorianMichael
Copy link
Member

@lowercasebtw I would recommend opening multiple issues for the things you mentioned with a more detailed description of the problem (appending screenshots or a video would be helpful). If you manage to fix things up yourself, you can open pull requests.

@NoboKik
Copy link

NoboKik commented Jun 7, 2024

Eating and clicking animations would be nice. Pretty sure in 1.7 if you are eating something and then holding left click and looking on the ground, it would swing the same way as if you were blocking the sword.

@lowercasebtw
Copy link
Collaborator

Implemented some of this stuff for 1.7 so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants