Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline template option to generator #1792

Open
Tracked by #1855
joelhawksley opened this issue Jul 3, 2023 · 9 comments
Open
Tracked by #1855

Add inline template option to generator #1792

joelhawksley opened this issue Jul 3, 2023 · 9 comments

Comments

@joelhawksley
Copy link
Member

Given that the --inline flag is already used, maybe --inline-template?

Originally posted by @Spone in #1781 (comment)

@Spone
Copy link
Collaborator

Spone commented Oct 17, 2023

We can also wait for v4 and make it a breaking change:

or we may want to change the default behavior?

@Spone
Copy link
Collaborator

Spone commented Mar 25, 2024

Happy to start working on this for v4 if we reach a consensus on the naming suggested above.

@joelhawksley
Copy link
Member Author

or we may want to change the default behavior?

I'm curious about this path. What do you think @BlakeWilliams @camertron @boardfish?

@BlakeWilliams
Copy link
Contributor

I think keeping the current default makes sense, unless we see a ton of adoption of the inline templates.

@camertron
Copy link
Contributor

Hmm... both in the code and in the docs, the word "inline" is used to mean a template string in the component, not a call method. IMHO it would be much clearer to repurpose the --inline flag to generate a component with a template string and introduce --call as the flag that generates a component with a call method. Obviously that's a breaking change and would have to be made in v4.

If we want to do this before v4, I would advocate for --inline-template as the flag that results in a component with an inline template string.

@reeganviljoen
Copy link
Collaborator

@camertron I think we should introduce this change with v4 as adding it to v3 only to remove it shortly after would be counter productive, we should add a warning to --inline that it will change in v4 as it stands though

@joelhawksley
Copy link
Member Author

@reeganviljoen I guess it depends on how long we think it will be until v4 😄

@reeganviljoen
Copy link
Collaborator

@joelhawksley i feel like a year feels realistic, but maybe we should add a time line

@joelhawksley
Copy link
Member Author

For something like a generator command line flag, I think we should just wait until the next major release if we think it's a year or so out ❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants