-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inline template option to generator #1792
Comments
We can also wait for v4 and make it a breaking change:
or we may want to change the default behavior? |
Happy to start working on this for v4 if we reach a consensus on the naming suggested above. |
I'm curious about this path. What do you think @BlakeWilliams @camertron @boardfish? |
I think keeping the current default makes sense, unless we see a ton of adoption of the inline templates. |
Hmm... both in the code and in the docs, the word "inline" is used to mean a template string in the component, not a If we want to do this before v4, I would advocate for |
@camertron I think we should introduce this change with v4 as adding it to v3 only to remove it shortly after would be counter productive, we should add a warning to --inline that it will change in v4 as it stands though |
@reeganviljoen I guess it depends on how long we think it will be until v4 😄 |
@joelhawksley i feel like a year feels realistic, but maybe we should add a time line |
For something like a generator command line flag, I think we should just wait until the next major release if we think it's a year or so out ❤ |
Given that the
--inline
flag is already used, maybe--inline-template
?Originally posted by @Spone in #1781 (comment)
The text was updated successfully, but these errors were encountered: