Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing for the next minor Ruby version #2033

Open
boardfish opened this issue May 27, 2024 · 4 comments
Open

Preparing for the next minor Ruby version #2033

boardfish opened this issue May 27, 2024 · 4 comments
Assignees

Comments

@boardfish
Copy link
Collaborator

It seems as though the next Ruby version will default to string literals being frozen. The linked gist outlines some things we can add to CI to make sure we're not falling foul of this.

Depending on whether there are any violations or not, we could enforce it strictly or add it as a test matrix option that we don't require in order for CI to pass. Happy to pick this up myself in the near future.

@boardfish boardfish self-assigned this May 27, 2024
@reeganviljoen
Copy link
Collaborator

reeganviljoen commented May 27, 2024

@boardfish in #2030 I also noticed a tests that was failing because of mismatched regex/string encodings I wonder if this is a bug in ruby(no mention in https://bugs.ruby-lang.org/) or a breaking change, just thought its worth noting

@boardfish
Copy link
Collaborator Author

Interesting! Good to see that testing against Ruby head is proving itself useful already ✨

@reeganviljoen
Copy link
Collaborator

@boardfish I am seeing a lot of these warnings, what strategy do you think we should use to collect and diagnose which dependencies they are coming from

@reeganviljoen
Copy link
Collaborator

@boardfish I have been thinking about this, since the release is so nearby this is quite important now, maybe we could do a test run, with some kind of mechanism to catch any warnings against ruby main, then report any issues to our dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants