expand allowed types for tableRefFor and tableNameFor

it fixes: Argument of type 'ModelClass<Foo>' is not assignable to parameter of type 'typeof Model'
Vincit · Apr 26, 2023 · 315535d · 315535d
1 parent 123efe2
commit 315535d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/tests/ts/examples.ts b/tests/ts/examples.ts
@@ -833,6 +833,7 @@ const modelFromQuery = qb.modelClass();
 const knexQuery = qb.toKnexQuery().toSQL();
 const tableName: string = qb.tableNameFor(Person);
 const tableRef: string = qb.tableRefFor(Person);
+const tableRefModelClass: string = qb.tableRefFor(modelFromQuery);
 
 function noop() {
   // no-op

diff --git a/typings/objection/index.d.ts b/typings/objection/index.d.ts
@@ -690,7 +690,7 @@ declare namespace Objection {
   }
 
   interface TableRefForMethod {
-    (modelClass: typeof Model): string;
+    (modelClass: ModelClass<Model> | typeof Model): string;
   }
 
   interface AliasForMethod<QB extends AnyQueryBuilder> {