Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: losing aliasMap in 'partial' subqueries #2405

Merged
merged 3 commits into from
May 17, 2023

Commits on Apr 22, 2023

  1. fix: losing aliasMap in 'partial' subqueries

    This fixes an issue with 'partial' suibqueries that they lose `aliasMap` from `q._context`
    (QueryBuilder's "internal context") while generating nested `where` sql part.
    `QueryBuilder.subqueryOf()` used to grab context from "parent" query, but it doesn't anymore. (since 2019-02-13)
    Vincit@524e0be
    
    Basically reintroducing what was deleted in Vincit@524e0be but wrap merging context with a condition that it should only apply to "partial" subqueries + reverse the sequence that `isPartial()` is set before `subqueryOf()`
    falkenhawk committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    34105a5 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. let -> const

    Co-authored-by: Elan Ruusamäe <[email protected]>
    falkenhawk and glensc committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    5770cbd View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. added test which fails without the fix

    with error: `no such column: model2.model2_prop2`
    falkenhawk committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    f9ebd82 View commit details
    Browse the repository at this point in the history