Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand allowed types for tableRefFor and tableNameFor #2408

Merged
merged 1 commit into from
May 19, 2023
Merged

expand allowed types for tableRefFor and tableNameFor #2408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/ts/examples.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,6 +833,7 @@ const modelFromQuery = qb.modelClass();
const knexQuery = qb.toKnexQuery().toSQL();
const tableName: string = qb.tableNameFor(Person);
const tableRef: string = qb.tableRefFor(Person);
const tableRefModelClass: string = qb.tableRefFor(modelFromQuery);

function noop() {
// no-op
Expand Down
2 changes: 1 addition & 1 deletion typings/objection/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,7 @@ declare namespace Objection {
}

interface TableRefForMethod {
(modelClass: typeof Model): string;
(modelClass: ModelClass<Model> | typeof Model): string;
}

interface AliasForMethod<QB extends AnyQueryBuilder> {
Expand Down