Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala CLI does not detect if is run as scala when installed using coursier #1307

Closed
romanowski opened this issue Aug 30, 2022 · 1 comment · Fixed by #1368
Closed

Scala CLI does not detect if is run as scala when installed using coursier #1307

romanowski opened this issue Aug 30, 2022 · 1 comment · Fixed by #1368
Assignees
@lwronski
Labels
SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command.

Comments

@romanowski
Copy link
Member

Version(s)

0.1.12

Describe the bug
Scala CLI does not detect if is run as scala when installed using coursier

To Reproduce

Install Scala CLI as scala-cli-sip using following command:

cs install --channel https://gist.githubusercontent.com/romanowski/f188a22999bbfd90d5ae7c054d41a0ae/raw/25e0f12491b65c4af5a9166fccf9cffbd5143e3e/scala-cli-sip-channel.json scala-cli-sip

Then scala-cli publish --help should fail, but it prints the help.

Expected behaviour
Scala CLI should detect if installed in the SIP mode when using coursier.
@romanowski romanowski added the SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command. label Aug 30, 2022
@romanowski romanowski mentioned this issue Aug 30, 2022
Merged
@romanowski
Copy link
Member Author

Suggestion from @lwronski :

coursier stores the binary file under the name .scala-cli-sip.aux, therefore the sip detection mechanism does not work.
If we strip suffix .aux here - it should works, but it is more kind of workaround

@lwronski lwronski linked a pull request Sep 14, 2022 that will close this issue
Detect sip when installed by coursier #1368
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lwronski lwronski

Labels
SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command.
Projects
Issue Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Detect sip when installed by coursier lwronski/scala-cli
3 participants
@romanowski @alexarchambault @lwronski