Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test fails even in clean checkout #274

Open
SethTisue opened this issue Mar 13, 2024 · 9 comments
Open

Integration test fails even in clean checkout #274

SethTisue opened this issue Mar 13, 2024 · 9 comments
Labels

Comments

@SethTisue
Copy link
Contributor

sbt:scala-yaml> integration/test
org.virtuslab.yaml.K8sConfigSpec:
==> X org.virtuslab.yaml.K8sConfigSpec.initializationError  0.001s java.lang.NullPointerException: null
    at org.virtuslab.yaml.YamlRunnerSpec.<init>(YamlRunnerSpec.scala:14)
    at org.virtuslab.yaml.K8sConfigSpec.<init>(K8sConfigSpec.scala:3)
Error in test - /Users/tisue/scala-yaml/integration-tests/target/scala-2.13/test-classes/yaml/test-suite/9DXL.tml
Events differ - /Users/tisue/scala-yaml/integration-tests/target/scala-2.13/test-classes/yaml/test-suite/RXY3.tml
Error in test - /Users/tisue/scala-yaml/integration-tests/target/scala-2.13/test-classes/yaml/test-suite/M5DY.tml
Error in test - /Users/tisue/scala-yaml/integration-tests/target/scala-2.13/test-classes/yaml/test-suite/SF5V.tml
Error in test - /Users/tisue/scala-yaml/integration-tests/target/scala-2.13/test-classes/yaml/test-suite/Q9WF.tml
...

this came up in the context of scala/community-build#1713

@SethTisue
Copy link
Contributor Author

SethTisue commented Mar 13, 2024

I think this was missed until now because the GitHub Actions config in this repo only runs core/test and does not run integration/test cc @tgodzik

@tgodzik
Copy link
Member

tgodzik commented Mar 13, 2024

I will take a look, thanks!

@lbialy lbialy added bug Something isn't working test labels May 10, 2024
@lbialy
Copy link
Contributor

lbialy commented May 10, 2024

@kpodsiad hey Kamil, while you're available - what was the highest percent of green tests in this suite, ever? I've seen 44% green in your older PR but current main is around 40%.

@kpodsiad
Copy link
Contributor

@lbialy sorry, I don't remember. But some heads up - they yaml that almost everyone on daily basis is only a small fraction of yaml spec, spec itself is enormous and contains things that no sane person would use like #24. It might be good idea to determine subset of currently available tests / cases which needs to supported and leave the rest as a fun fact, something maybe nice to have, but absolutely non necessary for 99% of usecases.

@lbialy lbialy removed the bug Something isn't working label Jul 12, 2024
@lbialy
Copy link
Contributor

lbialy commented Jul 12, 2024

We should track the percent covered by the suite I guess.

@lbialy
Copy link
Contributor

lbialy commented Jul 21, 2024

Uh, main today is at 36.65% :/

@lbialy
Copy link
Contributor

lbialy commented Jul 21, 2024

And k8s spec is at 62.60%

@lbialy
Copy link
Contributor

lbialy commented Jul 21, 2024

no improvement after merge of all bugfixes 😞 😭

@lbialy
Copy link
Contributor

lbialy commented Jul 22, 2024

I have added outputYaml checking in official yaml test suite and now it's 14.60% from 36.65% ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants