Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: underscores in numeric literals #48

Closed
wants to merge 21 commits into from

Conversation

latonis
Copy link
Contributor

@latonis latonis commented Oct 19, 2023

Work to implement and close #14

  • modified pest grammar to allow for underscores following at least one number in a numeric literal, including floating point and those ending with the size suffixes
  • added tests as well

Also tested with the following rule

rule test {
  condition:
    2_000 == 2000 and 100KB == 1_00KB and 0o12 == 1_0 and 0x2_1 == 0x21 and 0x31_1 == 7_8_5
}

@latonis
Copy link
Contributor Author

latonis commented Aug 27, 2024

this is no longer relevant with the parser rewrite i believe, closing

@latonis latonis closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow using underscores (_) as part of numeric literals
1 participant