Mod dublication bug 2

[66BA9Q-ME49]

Is there an existing issue for this?

• I have searched the existing issues

Launcher Version

0.46.0

Operating System

Windows

Architecture

x64

Current Behavior

Sometimes I have two different enabled versions of a same mod.
It seems that XMCL treats the Modrinth and Curseforge version of some mods as different mods, which causes this problem. It doesn't occur for all mods, though.

For example, XMCL treats the Curseforge and Modrinth version of Oh The Biomes You'll Go (BYG) as a same mod. But for some mods like Just Enough Items (JEI), it doesn't.
I think it's because the version names are different:

	Modrinth	Curseforge
BYG	Oh_The_Biomes_You'll_Go-forge-1.19.2-[version]	Oh_The_Biomes_You'll_Go-forge-1.19.2-[version]	=
JEI	[version] for Forge 1.20.1	jei-1.20.1-forge-[version]	≠

Expected Behavior

XMCL should treat the Modrinth and Curseforge version of any mod as a same mod. This should avoid duplicated jar files.

Steps To Reproduce

For mods:

• Install a mod from Modrinth.
• Install a different version of the same mod from Curseforge.
• Two different versions of the same mod are installed.

Same for dependencies:

• Install from Modrinth a mod which requires a dependency.
• Install from Curseforge a mod which requires a different version of the dependency.
• Two different versions of the same dependency are installed.

Anything else?

Here is the video showing the bug:

Bug00.mp4

I initially mentioned this bug in #712 along with another mod duplication bug, but I moved it to this new issue because I found it weird to have 2 issues in one issue.

[66BA9Q-ME49]

Still happening on 0.47.4.

[ci010]

It's hard to detect all these kind of situation. But currently, the launcher is doing such thing to mitigate this issue.

1. Maintain a mapping between curseforge and modrinth. In the future, we could merge curseforge and modrinth search result into one item.
2. Maintain a mapping between curseforge id, modrinth id and modId. In the future, we could check the existed modId and pending installing modId to prevent installation. Though, this won't work perfect, as the are too many modId...
3. Add UI to warn user the mods are duplicated. See discord https://discord.com/channels/405213567118213121/990258414900879390/1296005278063661167

[66BA9Q-ME49]

I understand. The new UI allowing to choose which file to keep is really good, and in my opinion almost solves this issue. Despite these bugs, this launcher is almost perfect and I love it.
This is the best launcher I could find (and I searched a lot), so thanks a lot to all the persons working on it! You're doing an amazing job!