Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hasMany/hasOne do not check document access authorization on resolved documents #71

Open
eric-burel opened this issue Aug 27, 2021 · 0 comments
Open

hasMany/hasOne do not check document access authorization on resolved documents #71

eric-burel opened this issue Aug 27, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@eric-burel
Copy link
Collaborator

eric-burel commented Aug 27, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

  • We should share more code between single, multi, hasOne, and hasMany resolver, a bit like we do for mutators.
  • We need to check that hasMany/hasOne cannot be resolved on field user is not allowed to read (normally it's the case already but this deserves a unit test on its own=
  • We need to filter the list of documents user can read in relations, mainly when the permission is "owners", this is not the case yet (we however filter fields correctly in the related document)
@eric-burel eric-burel added the enhancement New feature or request label Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eric-burel