return NaN, not zero, in metadata export for bins w/o depth information

[joefutrelle]

No description provided.

[joefutrelle]

During metadata upload, a depth value for a bin is not set if there is no value in the uploaded CSV:

ifcbdb/ifcbdb/dashboard/accession.py

Lines 368 to 371 in 36cac45

	if depth_col is not None:
	depth = get_cell(row, depth_col)
	if depth is not None:
	b.depth = depth

During metadata download, there are three cases: 1) depth is set on the bin, 2) depth is set on the dataset, and 3) depth is NaN.

ifcbdb/ifcbdb/dashboard/accession.py

Lines 521 to 526 in 36cac45

	if item['depth'] is not None:
	add('depth')
	elif dataset_depth is not None:
	r['depth'].append(dataset_depth)
	else:
	r['depth'].append(np.nan)

[joefutrelle]

This code may be relevant as well, since it's used in metadata upload and relies on pd.isnull.

ifcbdb/ifcbdb/dashboard/accession.py

Lines 287 to 296 in 36cac45

	def get_cell(named_tup, key):
	val = getattr(named_tup, key)
	try:
	if pd.isnull(val):
	return None
	else:
	return val
	except TypeError:
	return val

[mike-kaimika]

@joefutrelle On the master branch, I'm not seeing things as outline in the original description here. I have a dataset where a few of the bins do not have depths set, and the value that comes out in the CSV file is an empty string, rather than a zero. Is that the expected outcome of this ticket (in which case, no changes are needed)?

My other thought would be that you might want an explicit NaN value in the CSV - we can do that with an argument to represent NaN values with some other string:
df.to_csv(csv_buf, mode='wb', na_rep='NaN', **kw)

However, should that affect other columns besides depth as well? For example, the above change worked on the depth column, but you can see it also produced NaN values for latitude, longitude an some other columns as well

[joefutrelle]

I'm removing this from 4.2 until we can do more investigation.