Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it more clear that WICG drafts should use CG-DRAFT instead of ED #90

Closed
jyasskin opened this issue Feb 10, 2020 · 9 comments · Fixed by speced/bikeshed#1602
Closed

Comments

@jyasskin
Copy link
Member

Forked from discussion in #79 (comment) and w3c/tr-design#186 (comment). See also #64.

I didn't realize that the ED status was meant for WG drafts, and that editor's drafts of CG specifications should use CG-DRAFT instead. It looks like lots of other editors have the same confusion. CGs generally should find a way to educate editors on this, but the WICG is as good a place as any to start looking for ways that work.

One thought is to edit https://github.com/tabatkins/bikeshed/tree/master/bikeshed/boilerplate/wicg to add a header-ED.include that loudly says to use the CG-DRAFT status instead. @tabatkins, does that make sense?

What other approaches should we try?

This is also a good place to disagree if the policy @marcoscaceres suggested is wrong for some reason. 😃

@tabatkins
Copy link

I could do that, or just have a check in Bikeshed that if your group is WICG and your status isn't one of the WICG statuses, it throws a fatal error.

Maybe pair that with an ED boilerplate that looks terrible too, in case people ignore the error. ^_^

@jyasskin
Copy link
Member Author

If Bikeshed were to actually have logic for this, I'd want it to identify all CGs to treat them uniformly, and probably ban all of the WG statuses. The ED boilerplate was the cheap idea. But maybe we can identify CG groups because they end with "cg"?

@marcoscaceres
Copy link
Contributor

Something like that might work. Definitely worth investigating.

@jyasskin
Copy link
Member Author

jyasskin commented Feb 11, 2020

Marcos also found a draft that forgot to set a Group despite being in the WICG Github org. We could detect that either by having Bikeshed constrain the acceptable groups based on the Repository or by telling Github to run some lint check across the whole org.

@marcoscaceres
Copy link
Contributor

telling Github to run some lint check across the whole org.

I had no idea one could do that. Do you have a link to some docs or an example? I guess it could be as simple as find *.bs and then grep'ing for Group:\s+WICG or similar.

@jyasskin
Copy link
Member Author

I think we could write a Github App to lint specs on each PR, and install it across the whole org. I suspect the Bikeshed patch will be easier.

@tabatkins
Copy link

Yeah, and I'm happy to write or accept such a patch.

@hober
Copy link
Contributor

hober commented Jul 14, 2020

I'm pretty sure some recent-ish Bikeshed changes I've made take care of this, though it warns, it doesn't error. (You can always --die-on=warning if you want that. See speced/bikeshed#1663 speced/bikeshed#1684 for the relevant changes.)

Maybe this can be closed now?

@marcoscaceres
Copy link
Contributor

Filed a bug on ReSpec https://github.com/w3c/respec/issues/3017 ... can follow up there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants