Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve interactive behavior #12

Open
yisibl opened this issue Aug 31, 2021 · 4 comments
Open

Improve interactive behavior #12

yisibl opened this issue Aug 31, 2021 · 4 comments

Comments

@yisibl
Copy link

yisibl commented Aug 31, 2021

I plan to migrate the color picker in Chrome Devtools to the EyeDropper API, but there are currently several problems:

  1. There is no independent cursor on the left side of the magnifying glass (the magnifying glass will cover the content at the bottom of the screen, making it difficult to move the cursor)
  2. It is not possible to continuously click to select the color.

image

@yisibl yisibl changed the title Match the behavior of Chrome Devtools Improve interactive behavior Aug 31, 2021
@ipopescu93
Copy link
Collaborator

I plan to migrate the color picker in Chrome Devtools to the EyeDropper API, but there are currently several problems:

Thanks for the issue and for the work to integrate the API in Chrome Devtools!

  1. There is no independent cursor on the left side of the magnifying glass (the magnifying glass will cover the content at the bottom of the screen, making it difficult to move the cursor)

The user agent has the freedom to implement eyedropper pixel selection UI that bests fits their platform and follows these rules. I am going to follow up on the crbug for the Chromium specific UI.

  1. It is not possible to continuously click to select the color.

image

This is a security mitigation as we don't want a web page to be able to "screen scrape" information the user didn't intend to share while moving the mouse around the screen. We are evaluating allowing the selection of multiple colors by reopening the eyedropper in the same event handler (see #9).

@yisibl
Copy link
Author

yisibl commented Sep 1, 2021

@ipopescu93 Thank you for your reply.

Add a question:
currently right clicking will also absorb the color, is it better to be consistent with the behavior of ESC key?

@jespertheend
Copy link

I also think it could be very valuable to be able to click and hold in order to directly see the result of picking a color before releasing. Is there anything that could be done to make this more secure? Perhaps the same solutions from #13 could apply here as well.

@Kilian
Copy link

Kilian commented Oct 26, 2021

Point number 2 is also captured in #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants