Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials mode "omit" incompatible with HTML's navigate #21

Open
annevk opened this issue Aug 7, 2017 · 4 comments
Open

Credentials mode "omit" incompatible with HTML's navigate #21

annevk opened this issue Aug 7, 2017 · 4 comments

Comments

@annevk
Copy link

annevk commented Aug 7, 2017

If the origin policy is to be fetched with credentials mode being "omit", it'll end up using a separate HTTP connection unless whatwg/fetch#341 is fixed in all implementations somehow.

And I do think we want credentials mode to be "omit", especially if we want to fetch these resources out-of-band. (One could imagine a user agent gathering these from useragentserverfarm.com and then sending the appropriate ones to the end user in some kind of compressed format.)

@mikewest
Copy link
Member

mikewest commented Aug 9, 2017

Very fair. Hrm.

I imagine that most folks who deploy this kind of policy will be pushing the policy down before it's requested, along the lines of https://wicg.github.io/origin-policy/#server-push. It's not really clear to me how the push cache will interact with Fetch's credentials mode. "push" doesn't appear in Fetch, and I haven't poked at Chrome's implementation to see whether we split the cache based upon the original connection type. @sleevi probably knows?

I'm open to suggestions here...

@annevk
Copy link
Author

annevk commented Aug 9, 2017

The push cache as I understand it is tied to the connection. It would end up failing in existing implementations.

@sleevi
Copy link

sleevi commented Aug 9, 2017

@mikewest As @annevk said, the push cache is tied to the connection, the connection is tied to the socket pool (connection group in fetch, IIRC), and the socket pool/connection group is tied to credentials mode. So it'd happen as @annevk said.

@domenic
Copy link
Collaborator

domenic commented Nov 19, 2019

2+ years later, how do people feel about changing the credentials mode to "include", to match navigation? If I recall, 2 years ago we were more bullish about making "omit" the default.

It seems like if we want H/2 pushing a policy, or any sync update at all, to be feasible, then we really need to stay on the same connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants