-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isEncapsulated naming #107
Comments
Well, there's precedent in "isTrusted", but I'd prefer the non-is-prefixed name :) |
Yeah, I welcome any opinion. Actually, I've spent only a few minutes to give it a name. :) Because is-prefix is less-loved recently, I've changed it I think we still need a better idea. I don't want to expose a term of 'encapsulation' to the APIs. The candidates:
What makes the naming difficult is that the event which is encapsulated doesn't always stop at a shadow root if distribution is involved in the event path. e.g. Event path in this case: [L, P, R, Q, O, N, K, J] |
Isn't the semantic that the event is scoped to a subtree? |
I like sticking to the semantic. If this is true, then +1 to @annevk |
Thank you for the feedback. I'm afraid that it might be ambiguous what subtree means here. Here, we're scoping the event to sub-tree-of-trees. |
|
Thanks, however, I'm still reluctant to expose the term of subtree. DeepSubtree sounds an attractive candidate, but I have a concern that developers have a wrong impression that the event is not dispatched to the parent node of the event.target by the name of I welcome any wording which doesn't use
I'm aware that both are not good name. |
The second one of those seems somewhat reasonable. Maybe |
I think we should add |
Propagates does not make sense for the capturing phase I think. But maybe |
True, |
Thanks for the feedback. I appreciate it. I thought the same thing, like a 'event.xxxShadowHost', though I don't remember 'XXX'. However, I abandoned it because I thought that it might impress developers that event is dispatched to only the shadow host (+ ancestor chain in the current node tree, of course), excluding the ancestor nodes of the shadow host. Am I worrying too much? In addition to that,
|
At the same time, as @annevk mentioned, I want to avoid the tree terminology here as much as possible. |
I don't think I don't think there's any reason to avoid the word tree here. |
Thanks. The term of the shadow tree is okay to use. I just wanted to avoid to use other term such as "ancestorTress", "inclusiveDescendantTrees" because it should be "ancestorNodeTrees", "inclusiveDescendantNodeTrees" in a strict meaning. I omitted "Node" in the spec. Yeah, I prefer the naming which is false by default. WDYT about |
Otherwise, simply, how about |
I see. I think |
Thanks. Let's change it to |
adae25b introduced the isEncapsulated flag to solve #61. It seems pretty great!
However, the naming is a bit weird.
bubbles
andcancelable
are the models to follow here. So,encapsulated
makes more sense.The text was updated successfully, but these errors were encountered: