Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Largo's pseudoelement lines at top and bottom of pull quotes; replace with actual borders so that Gutenberg's pull quote "primary color" selector works. #1748

Open
3 tasks
benlk opened this issue Jul 16, 2019 · 1 comment
Labels
category: gutenberg Relating to general Gutenberg compatibility category: styles affects lots of styles, requiring visual testing Estimate: < 6 Hours type: bug type: improvement

Comments

@benlk
Copy link
Collaborator

benlk commented Jul 16, 2019

In be30571 in #1746, as a quick fix for the issue where Gutenberg's editor styles provided thick 4px borders top and bottom to pull quotes that duplicated Largo's built-in borders top and bottom, I hid Gutenberg's borders in the editor.

They were already hidden in the frontend; this bug is not new in #1746. All #1746 did was hide the Gutenberg-provided, Gutenberg-styled borders in the editor.

However, those borders are the elements that get colored by the inline border-color styles set by the "Main Color" control on the pull quote block.

Screen Shot 2019-07-16 at 16 19 59
Screen Shot 2019-07-16 at 16 20 08

Steps to fix:

  • Remove Largo's pseudoelement ::before and ::after lines
  • Replace them with borders
    • check padding/spacing/margins to nearby content
  • Test this change against:
    • pull quote blocks
    • blockquote blocks with an added .type-pull-quote class
    • Module Wrapper content
    • other testing concerns in Block quote styles #1687
@benlk benlk added category: gutenberg Relating to general Gutenberg compatibility type: bug labels Jul 16, 2019
@benlk benlk added category: styles affects lots of styles, requiring visual testing Estimate: < 6 Hours type: improvement labels Jul 16, 2019
@benlk
Copy link
Collaborator Author

benlk commented Aug 12, 2019

Example styles for this can be seen in INN/umbrella-workdayminn#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: gutenberg Relating to general Gutenberg compatibility category: styles affects lots of styles, requiring visual testing Estimate: < 6 Hours type: bug type: improvement
Projects
None yet
Development

No branches or pull requests

1 participant