From ac4129eccc0834208e34e024229c423947444ff5 Mon Sep 17 00:00:00 2001 From: Washi Date: Wed, 15 Mar 2023 16:57:31 +0100 Subject: [PATCH] Simplify, fix code typos in docs. --- docs/dotnet/type-signatures.rst | 4 ++-- .../Signatures/Types/ArrayBaseTypeSignature.cs | 3 +++ src/AsmResolver.DotNet/Signatures/Types/ArrayTypeSignature.cs | 3 --- .../Signatures/Types/SzArrayTypeSignature.cs | 3 --- 4 files changed, 5 insertions(+), 8 deletions(-) diff --git a/docs/dotnet/type-signatures.rst b/docs/dotnet/type-signatures.rst index 219d9555a..e98940e72 100644 --- a/docs/dotnet/type-signatures.rst +++ b/docs/dotnet/type-signatures.rst @@ -274,7 +274,7 @@ These rules are implemented in AsmResolver using the ``IsCompatibleWith`` and `` .. code-block:: csharp - if (comparer.IsCompatibleWith(type1, type2)) + if (type1.IsCompatibleWith(type2)) { // type1 can be converted to type2. } @@ -282,7 +282,7 @@ These rules are implemented in AsmResolver using the ``IsCompatibleWith`` and `` .. code-block:: csharp - if (comparer.IsAssignableTo(type1, type2)) + if (type1.IsAssignableTo(type2)) { // Values of type1 can be assigned to variables of type2. } diff --git a/src/AsmResolver.DotNet/Signatures/Types/ArrayBaseTypeSignature.cs b/src/AsmResolver.DotNet/Signatures/Types/ArrayBaseTypeSignature.cs index c5902afe2..ee77d817b 100644 --- a/src/AsmResolver.DotNet/Signatures/Types/ArrayBaseTypeSignature.cs +++ b/src/AsmResolver.DotNet/Signatures/Types/ArrayBaseTypeSignature.cs @@ -16,6 +16,9 @@ protected ArrayBaseTypeSignature(TypeSignature baseType) { } + /// + public override bool IsValueType => false; + /// /// Gets the number of dimensions this array defines. /// diff --git a/src/AsmResolver.DotNet/Signatures/Types/ArrayTypeSignature.cs b/src/AsmResolver.DotNet/Signatures/Types/ArrayTypeSignature.cs index d1b0d5659..056f943f6 100644 --- a/src/AsmResolver.DotNet/Signatures/Types/ArrayTypeSignature.cs +++ b/src/AsmResolver.DotNet/Signatures/Types/ArrayTypeSignature.cs @@ -58,9 +58,6 @@ public ArrayTypeSignature(TypeSignature baseType, params ArrayDimension[] dimens /// public override string Name => $"{BaseType.Name ?? NullTypeToString}{GetDimensionsString()}"; - /// - public override bool IsValueType => false; - /// /// Gets a collection of dimensions. /// diff --git a/src/AsmResolver.DotNet/Signatures/Types/SzArrayTypeSignature.cs b/src/AsmResolver.DotNet/Signatures/Types/SzArrayTypeSignature.cs index 1c5fb2950..c0286ccf9 100644 --- a/src/AsmResolver.DotNet/Signatures/Types/SzArrayTypeSignature.cs +++ b/src/AsmResolver.DotNet/Signatures/Types/SzArrayTypeSignature.cs @@ -25,9 +25,6 @@ public SzArrayTypeSignature(TypeSignature baseType) /// public override string Name => $"{BaseType.Name ?? NullTypeToString}[]"; - /// - public override bool IsValueType => false; - /// public override int Rank => 1;