"set -u" and "if [ -z ${variable} ]" in ICAFIX/ReApplyFixPipeline.sh

[joowon-kim]

Dear the HCP team,

"set -u" was set at

HCPpipelines/ICAFIX/ReApplyFixPipeline.sh

Line 35 in 9f52e6b

set -eu

and "if [ -z ${variable} ]" was used in the same file at multiple lines.

This raises an error if the variable is undefined. The ${variable} in the if line should be replaced with ${variable:-} like

HCPpipelines/ICAFIX/ReApplyFixPipeline.sh

Line 38 in 9f52e6b

if [[ "${HCPPIPEDIR:-}" == "" ]]

Best,
Joo-won

[coalsont]

Ah, I see, specifically FSL_FIX_MCR. We may not have tested compiled mode after that change. The other variables are defined by the script, so they shouldn't trip set -u (even if they are the empty string).

[coalsont]

Please see if b4f33c5 runs to completion.

[joowon-kim]

It works. The same thing is in the multirun pipeline

HCPpipelines/ICAFIX/ReApplyFixMultiRunPipeline.sh

Line 704 in b4f33c5

if [ -z "${FSL_FIX_MCR}" ]; then

[coalsont]

Should be fixed by f41f729