Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scout v2 + its different usage for scanZone/scanNext #942

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Scout v2 + its different usage for scanZone/scanNext #942

merged 6 commits into from
Jan 30, 2024

Conversation

kamieniarz
Copy link
Contributor

@kamieniarz kamieniarz commented Jan 29, 2024 •
edited
Loading

Changes:

  • New platform: dragonite. It fully supports scout v2, custom stays unchanged. There's no need to change scout apiEndpoint if you switch from custom to dragonite
  • Using dragonite platform requires at least Dragonite v1.5.0
  • Params routes, showcases, pokemon and gmf were added separately to scanZone and scnaNext so you could set them as I did in default - scanZone is clearly used to scan mons while scanNext is used to scan routes, gmf and showcases details which may cause jump delays so it's proly worth to increase userCooldownSeconds in that case

@kamieniarz kamieniarz mentioned this pull request Jan 29, 2024
Closed
TurtIeSocks
TurtIeSocks requested changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@TurtIeSocks TurtIeSocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems fine. I haven't familiarized myself with the V2 scout API but is having a separate apiQueueEndpoint config value necessary? Left a couple of comments to adjust as well. Thanks and good job.

server/src/services/api/scannerApi.js Outdated Show resolved Hide resolved
server/src/configs/default.json Outdated Show resolved Hide resolved
@kamieniarz
Copy link
Contributor Author

I changed the approach

lenisko
lenisko approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@lenisko lenisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for changes

TurtIeSocks
TurtIeSocks approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@TurtIeSocks TurtIeSocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks!

@TurtIeSocks TurtIeSocks merged commit cc54b12 into WatWowMap:develop Jan 30, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Jan 30, 2024
@semantic-release-bot
chore(release): v1.29.0-develop.19 [skip ci]
93dc2ae 
# [1.29.0-develop.19](v1.29.0-develop.18...v1.29.0-develop.19) (2024-01-30)

### Features

* Merge pull request [#942](#942) from kamieniarz/patch-1 ([cc54b12](cc54b12))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.29.0-develop.19 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Feb 5, 2024
@semantic-release-bot
chore(release): v1.29.0 [skip ci]
821a665 
# [1.29.0](v1.28.0...v1.29.0) (2024-02-05)

### Bug Fixes

* `this.refetch` check ([e57f1b0](e57f1b0))
* active weather ([6541aa8](6541aa8))
* add search log tag ([fbb781a](fbb781a))
* add time log ([3acfef4](3acfef4))
* adjust expert description ([d6f04e0](d6f04e0))
* admin items ([7e6a62e](7e6a62e))
* adv filter options on mobile ([93234c3](93234c3))
* alignment uicons by id ([b17753f](b17753f))
* also show types in quick select ([c3f35dc](c3f35dc))
* always save new masterfile ([2f80d2c](2f80d2c))
* apply to all btns ([19997aa](19997aa))
* available for other permissions ([425ab3a](425ab3a))
* better regex for mapping minified errors ([cd0c28b](cd0c28b))
* better slide/input behaviors ([98686b8](98686b8))
* bunch of poracle webhook stuff ([fa4e628](fa4e628))
* caching ([bb74b24](bb74b24))
* ci commit messages ([ca42361](ca42361))
* circular ref ([0a212dd](0a212dd))
* cleanup from slot selection changes ([57ae335](57ae335))
* cleanups ([52690be](52690be))
* cleanups ([9ac88ca](9ac88ca))
* compare array sizes before updating ([b088b7b](b088b7b))
* couple of fixes ([ac2a1c5](ac2a1c5))
* disable prop for multiselector ([1cf4955](1cf4955))
* disable prop for size & gender ([33c6df7](33c6df7))
* disable sandbox ([fe93cfc](fe93cfc))
* ditto filtering ([2f6ddaa](2f6ddaa))
* don't always have to hit the limit ([39ac769](39ac769))
* dont show showcase mon if null ([e49b885](e49b885))
* dyslexia? ([3c25864](3c25864))
* enabled/all/disabled logic ([fc6c8ac](fc6c8ac))
* entering 0 on sliders ([0cb103c](0cb103c))
* export settings ([315508d](315508d))
* ez mode checks ([e2bb1f0](e2bb1f0))
* ez mode filter behavior ([0b0dd7d](0b0dd7d))
* fallback state ([5ea5d15](5ea5d15))
* favicon in dev ([353a7aa](353a7aa))
* fetch available in menus too ([55d2fc8](55d2fc8))
* filtering edge cases ([a1b1580](a1b1580))
* force ci? ([5026661](5026661))
* forgot my own type i18n keys ([d74f239](d74f239))
* fr showcase translation ([c0f74fb](c0f74fb))
* further dnf refinements ([da08236](da08236))
* global 0/100 iv toggles ([272d80d](272d80d))
* gql types ([e1e499a](e1e499a))
* gym badge fixes ([1cadea0](1cadea0))
* gym badge menu from popup ([8cea2fb](8cea2fb))
* gym badge page styling ([7016369](7016369))
* hide all logic in adv menu for some items ([0561829](0561829))
* hmm ([58d1ece](58d1ece))
* id when searching ([1802ca6](1802ca6))
* invasion quick selector ([ad4471a](ad4471a))
* issue in webhook adv menu ([190289a](190289a)), closes [#926](#926)
* lift version of ci ([4fd4bb6](4fd4bb6))
* locale dest ([8dd94c9](8dd94c9))
* make `allForms` false by default for usability ([cff0e23](cff0e23))
* make showcase icons smaller by default ([b0c587a](b0c587a))
* make the selector more generic friendly for other categories ([6259bc2](6259bc2))
* mega energy icons by id ([ced7d7c](ced7d7c))
* missing label on search ([36f2bd8](36f2bd8))
* missing translations ([4d6d5ec](4d6d5ec))
* more filter tweaks ([a4c4eee](a4c4eee))
* more limit adjustments ([6e6bbff](6e6bbff))
* more pokemon search refinements ([8fa91e1](8fa91e1))
* only show catchable shadow pokes ([fd519de](fd519de))
* only show edit adv for all for pokemon ([622f179](622f179))
* opening adv mode from drawer ([5c2f080](5c2f080))
* pokemon zoom ([9bbc70d](9bbc70d))
* pokestop marker adjustments ([c81340c](c81340c))
* poracle manager with new state fixes ([f4564ef](f4564ef))
* poracle saving/closing ([6251b5c](6251b5c))
* possible fix for leaflet location issue ([4aefb90](4aefb90))
* prop cleanups ([8b7d25d](8b7d25d))
* pvp mons with no iv perm ([fce7eb9](fce7eb9))
* quest conditions ([92af316](92af316))
* refine dnf filter generation ([875b961](875b961))
* release workflows ([6e8fa3c](6e8fa3c))
* remove `clear` icon for now ([58aed37](58aed37))
* remove `excludeList` - no longer needed ([bc3adba](bc3adba))
* remove blue from types ([33ffc13](33ffc13))
* remove log ([e572b3b](e572b3b))
* remove old eslint heading ([768affc](768affc))
* remove showcase on kecleon ([c42c9f4](c42c9f4))
* remove unnecessary r filters from quick select ([f0a3b28](f0a3b28))
* remove unused ([a0d1e6c](a0d1e6c))
* revert ([54d97fe](54d97fe))
* revert updating leaflet locate control ([97d9e07](97d9e07))
* rework ci/cd ([c6c7ed4](c6c7ed4))
* s2 cells ([2048b73](2048b73))
* saving and closing webhooks while editing ([ce9eb43](ce9eb43))
* search case sensitive in adv menu ([be5846d](be5846d))
* search fields ([581949c](581949c))
* search translations in webhook tracked ([5ef29ee](5ef29ee))
* search value clear ([05ae312](05ae312))
* search/setting filtered behavior ([a30c286](a30c286))
* searchable ([8f11741](8f11741))
* seeing if this helps ([044cd70](044cd70))
* show confirm switch if enabled ([2e03c50](2e03c50))
* showcase filtering ([8c9d08a](8c9d08a))
* showing feedback ([50b06c3](50b06c3))
* skip `h` filters on backend ([2020c40](2020c40))
* slider states when disabled ([4d88c1a](4d88c1a))
* slight optimization for query requests ([706581b](706581b))
* slightly more aggressive additions when there's 0 ([d062e52](d062e52))
* some pokestop filtering ([ef6be7f](ef6be7f))
* some state bugs ([2daf109](2daf109))
* standard filter backup ([5a0cdf5](5a0cdf5))
* state bug & consolidate translations ([d6e6a79](d6e6a79))
* state filter stuff ([70c958e](70c958e))
* stop crashing leaflet when map crashes ([45349be](45349be))
* string fallback ([11ce4ca](11ce4ca))
* submission cell menu items ([01c6350](01c6350))
* support for `all` in pokestop model ([cb57574](cb57574))
* title check ([7f10790](7f10790))
* top level state changes ([f401bbe](f401bbe))
* tut welcome page ([3c9e40c](3c9e40c))
* types ([360f87c](360f87c))
* uid for editing ([818a958](818a958))
* unknown shocases ([99cf89b](99cf89b)), closes [#941](#941)
* unmount scanAreas section ([49ec133](49ec133))
* updating robust timeout refetch fn ([ff84870](ff84870))
* user fields ([15ad84d](15ad84d))
* username fallback ([05261c1](05261c1))
* various webhook things ([a4b7db5](a4b7db5))
* vite config for `yarn start` ([1b1ea4a](1b1ea4a))
* vite prod build ([ed93946](ed93946))
* xxs/xxl names ([d6a8906](d6a8906))

### Features

* add searching ([356c01b](356c01b))
* cache all remote data for quicker startup ([befbc13](befbc13))
* dev settings in sidebar ([6a2651f](6a2651f))
* gym quick selector ([93c8fab](93c8fab))
* invasion searching ([63549eb](63549eb))
* invasions quick select ([c638225](c638225))
* literal easy mode ([5298676](5298676))
* lure quick selector ([98ee717](98ee717))
* Merge pull request [#942](#942) from kamieniarz/patch-1 ([cc54b12](cc54b12))
* nest quick select menu ([37761d7](37761d7))
* pokemon filter mode selector ([be846fc](be846fc))
* quest quick select menu ([02d8d65](02d8d65))
* quick select pkmn filters ([ee1010b](ee1010b))
* raids quick select menu ([dc3e10a](dc3e10a))
* respect global if no pkmn are active in basic mode ([c96c99f](c96c99f))
* rework how often available is updated ([ed35dcd](ed35dcd))
* show event stop markers if no quests/invasions ([32df5e9](32df5e9))
* showcase quick select ([1ae5fab](1ae5fab))
* showcase type id support ([45e5b1b](45e5b1b))
* tooltip ([a3777dd](a3777dd))
* useTranslateById AIO hook for ez key translations ([20dd65d](20dd65d))

### Performance Improvements

* improve pokestop querying perf by 10x ([f696b67](f696b67))
github-actions bot pushed a commit to ReuschelCGN/ReactMap that referenced this pull request Feb 7, 2024
@semantic-release-bot
chore(release): v1.2.0-develop.7 [skip ci]
38c3de0 
# [1.2.0-develop.7](v1.2.0-develop.6...v1.2.0-develop.7) (2024-02-07)

### Bug Fixes

* add search log tag ([fbb781a](fbb781a))
* add time log ([3acfef4](3acfef4))
* always save new masterfile ([2f80d2c](2f80d2c))
* bunch of poracle webhook stuff ([fa4e628](fa4e628))
* caching ([bb74b24](bb74b24))
* ci stuff ([7525855](7525855))
* circular ref ([0a212dd](0a212dd))
* compare array sizes before updating ([b088b7b](b088b7b))
* disable sandbox ([fe93cfc](fe93cfc))
* don't always have to hit the limit ([39ac769](39ac769))
* fallback state ([5ea5d15](5ea5d15))
* favicon in dev ([353a7aa](353a7aa))
* fetch available in menus too ([55d2fc8](55d2fc8))
* force ci? ([5026661](5026661))
* issue in webhook adv menu ([190289a](190289a)), closes [WatWowMap#926](https://github.com/ReuschelCGN/ReactMap/issues/926)
* lift version of ci ([4fd4bb6](4fd4bb6))
* locale dest ([8dd94c9](8dd94c9))
* more limit adjustments ([6e6bbff](6e6bbff))
* more pokemon search refinements ([8fa91e1](8fa91e1))
* needs & attempt to not run double ([abcaaab](abcaaab))
* needs both ([e4b7cec](e4b7cec))
* poracle saving/closing ([6251b5c](6251b5c))
* quest conditions ([92af316](92af316))
* release workflows ([6e8fa3c](6e8fa3c))
* remove unused ([a0d1e6c](a0d1e6c))
* revert ([54d97fe](54d97fe))
* revert updating leaflet locate control ([97d9e07](97d9e07))
* rework ci/cd ([c6c7ed4](c6c7ed4))
* run even when prev is skipped ([78c1404](78c1404))
* saving and closing webhooks while editing ([ce9eb43](ce9eb43))
* searchable ([8f11741](8f11741))
* seeing if this helps ([044cd70](044cd70))
* show confirm switch if enabled ([2e03c50](2e03c50))
* showcase filtering ([8c9d08a](8c9d08a))
* showing feedback ([50b06c3](50b06c3))
* simply ci ([ff0f718](ff0f718))
* slightly more aggressive additions when there's 0 ([d062e52](d062e52))
* stop crashing leaflet when map crashes ([45349be](45349be))
* test ([cb71760](cb71760))
* types ([360f87c](360f87c))
* uid for editing ([818a958](818a958))
* unknown shocases ([99cf89b](99cf89b)), closes [WatWowMap#941](https://github.com/ReuschelCGN/ReactMap/issues/941)
* username fallback ([05261c1](05261c1))
* vite config for `yarn start` ([1b1ea4a](1b1ea4a))

### Features

* cache all remote data for quicker startup ([befbc13](befbc13))
* invasion searching ([63549eb](63549eb))
* Merge pull request [WatWowMap#942](https://github.com/ReuschelCGN/ReactMap/issues/942) from kamieniarz/patch-1 ([cc54b12](cc54b12))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurtIeSocks TurtIeSocks TurtIeSocks approved these changes

@lenisko lenisko lenisko approved these changes

Assignees
No one assigned
Labels
released on @develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamieniarz @lenisko @TurtIeSocks