Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Clean up downloaded lib packages when the appconn engine exits #1085

Closed
2 tasks done
wxyn opened this issue Jul 11, 2023 · 1 comment
Closed
2 tasks done

Comments

@wxyn
Copy link
Contributor

wxyn commented Jul 11, 2023

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Problem Description

After the appconn engine exits, the downloaded appconn packages will not be automatically cleaned up in the engine directory, resulting in an increasing disk space usage. I hope that after optimization, the lib package downloaded by appconn can be automatically deleted when the engine exits.

Description

Due to the fact that the dss-appconns directory is not softlinked to public resources, each engine will download a new directory, resulting in disk usage. Therefore, when the appconn engine exits, it is necessary to clean the dss appconns directory.

Use case

No response

solutions

  1. Rewrite the hook method (ComputationExecutor. tryShutdown()) when the linkis engine exits in the AppConnEngineConnExecutor class, and add appconn's lib directory cleaning logic to this method.
  2. Reuse the AppConnUtils. getAppConnHomePath() method of existing tool classes to obtain the root directory of the appconn engine

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@wxyn wxyn added the enhancement New feature or request label Jul 11, 2023
@zqburde zqburde added type=NewFeature component=AppConns and removed enhancement New feature or request labels Aug 9, 2023
@zqburde
Copy link
Contributor

zqburde commented Aug 9, 2023

Add it in DSS1.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants