Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New factor should not created with deleted factor #133

Open
lwin-kyaw opened this issue May 3, 2024 · 1 comment
Open

New factor should not created with deleted factor #133

lwin-kyaw opened this issue May 3, 2024 · 1 comment

Comments

@lwin-kyaw
Copy link
Contributor

Steps to reproduce -

  • create mpc-corekit instance and login (instance1)
  • enable MFA on the instance1 and you should be able to get backup factor which will be used to login another session
  • create another corekit instance (instance2) and login with backup factor you have from above step
  • login should be successful with instance2
  • from instance1 delete the backup factor, which is used to login for instance2
  • verify the backup factor has been successfully deleted, as well as it's related metadata (commitChanges when using manualSync:true)
  • from instance2, try to create new factor with the deleted backup factor

Expected Result

From instance2, new factor should not be able to created, should throw factor not present error, since the active factor key of instance2 has been deleted from instance1

Actual Result

With deleted backup key, new factor can be created locally in instance2. MPC-Corekit throws an error only when sync with metadata service.

@lwin-kyaw
Copy link
Contributor Author

Make a fix here, 94574ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant