Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wasi thread_exit instead of proc_exit where appropriate #364

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use wasi thread_exit instead of proc_exit where appropriate #364

wants to merge 1 commit into from
+18 −2

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Dec 16, 2022

sbc100
sbc100 reviewed Dec 16, 2022
View reviewed changes
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming we have consensus on WebAssembly/wasi-threads#7

abrown
abrown reviewed Dec 16, 2022
View reviewed changes
Copy link
Collaborator

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, similar comment from me: let's wait on WebAssembly/wasi-threads#7

@sbc100
Copy link
Member

sbc100 commented Dec 16, 2022

Yeah, similar comment from me: let's wait on WebAssembly/wasi-threads#7

In that case we should completely remove pthread_exit from wasi-libc until that issue is resolved. Implementing pthread_exit using proc_exit (exit the whole process) is not correct, and we also want to know how many folks/app are going to just fail to build without pthread_exit existing at all.

@yamt
Copy link
Contributor Author

yamt commented Dec 17, 2022

Yeah, similar comment from me: let's wait on WebAssembly/wasi-threads#7

yes, that's why i made this a draft.

@yamt yamt mentioned this pull request Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 left review comments

@abrown abrown abrown left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yamt @sbc100 @abrown