Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix-MiniBrowser: page layout is broken after window resize in touch mode #33

Closed
ebalint opened this issue Oct 22, 2013 · 5 comments
Closed

Comments

@ebalint
Copy link

ebalint commented Oct 22, 2013

In touch mode, if you resize the window, in most of the cases the webpage's size doesn't adapt to the new window size.

@hugopl
Copy link
Member

hugopl commented Oct 22, 2013

Do you have some example or steps to reproduce this? I tried here and couldn't reproduce this.

@ebalint
Copy link
Author

ebalint commented Oct 22, 2013

Steps to reproduce: you open google.com in the MiniBrowser in touch mode. Then you resize the window to full size, and after that you resize it to previous size. The page will be smaller than the window, and there will be a blank space on the left side.

i'm working on this bug, and i've found a fix.

what do you think, is it okay?

patch:

https://gist.github.com/ebalint/4e6ecf189cb658bf3647

@ebalint
Copy link
Author

ebalint commented Oct 22, 2013

Beside this, i've found another problem with the window resizing / zooming. If you're on a page, and go to another page, then resize the window and go back to previous page, the zooming on the previous page will be incorrect. For this bug I haven't found a solution yet, but i'm working on it.

@hugopl
Copy link
Member

hugopl commented Oct 22, 2013

Your fix seems right.

I wasn't able to reproduce because the bug happens only when the maxinimize button is clicked, if the window is resized using the window border handlers the bug doesn't occur.

@qrwteyrutiyoup
Copy link
Member

Fixed by ca0a13c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants