Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis test gives an error after commit stage #149

Closed
bartnar opened this issue May 29, 2019 · 5 comments
Closed

Travis test gives an error after commit stage #149

bartnar opened this issue May 29, 2019 · 5 comments

Comments

@bartnar
Copy link

bartnar commented May 29, 2019

Cannot read property 'addExpectationResult' of undefined. Crashes at ex8
//////
const {task, css, html} = require('~utils')('ex8_html-css-basics', true, 'html');

describe('Ex8. HTML & CSS Basics', () => {
const tasks = Array.from({length: 4}).map((_, i) => 0${i + 1});

tasks.forEach(t =>
    task(t, markup => {
        it('html should be valid', html(markup));
        it('css should be valid', css(markup));
    }),
);

});
//////
jestjs/jest#5922

@elenap1991
Copy link
Contributor

Had same problem. Seems you have css validation fix. They fixed that at jestjs/jest#8005, you have to update jest version in your package.json, run npm install and update package-lock.json too, so travis would use new jest version. For example, i choosed to update to version 24.8.0, it helped to discover real errors

@eugrdn eugrdn closed this as completed Oct 23, 2019
@aneelia aneelia reopened this Nov 8, 2019
@VladimirEliseev
Copy link

/home/travis/build/VladimirEliseev/external-courses/node_modules/jest-jasmine2/build/jasmine/Env.js:534
currentRunnable().addExpectationResult(false, {
^
TypeError: Cannot read property 'addExpectationResult' of undefined
at Env.fail (/home/travis/build/VladimirEliseev/external-courses/node_modules/jest-jasmine2/build/jasmine/Env.js:534:24)
at Function.next.fail (/home/travis/build/VladimirEliseev/external-courses/node_modules/jest-jasmine2/build/queue_runner.js:52:22)
at fail (/home/travis/build/VladimirEliseev/external-courses/test-utils.js:71:37)
at ValidationStream. (/home/travis/build/VladimirEliseev/external-courses/node_modules/css-validator/lib/css-validator.js:20:7)
at ValidationStream.emit (events.js:210:5)
at /home/travis/build/VladimirEliseev/external-courses/node_modules/css-validator/node_modules/readable-stream/lib/_stream_readable.js:934:16
at processTicksAndRejections (internal/process/task_queues.js:75:11)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] test:ci: jest
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] test:ci script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/travis/.npm/_logs/2019-11-08T11_55_45_531Z-debug.log
The command "npm run test:ci" exited with 1.

@VladimirEliseev
Copy link

При создании Pull request указывал на ошибку в каком-то файле из предыдущих заданий. Я его удалил, ошибка ушла. Потом обновил Pull request также выдал ошибку из предыдущих заданий, после удаления этих файлов возникла эта ошибка.

@VladimirEliseev
Copy link

VladimirEliseev#9

@eugrdn
Copy link
Member

eugrdn commented Mar 1, 2020

Fixed in #201

@eugrdn eugrdn closed this as completed Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants