Commit not used when build fails

[niccokunzmann]

Describe the issue

I use hosted Weblate with web hook and Weblate Org installed, the project is Open-Web-Calendar.

When the build failed, the source strings were not updated.

I already tried

• I've read and searched the documentation.
• I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

1. Configure a component so that source files automatically get pulled from the repository into weblate
2. Make GitHub Actions fail (red)
3. change the source file by adding a translation string
4. Go to weblate -> manage -> pull the repository
5. notice that the source language translation does not update
6. make GitHub Actions run (green)
7. The source string gets loaded into Weblate

Expected behavior

I expected the source string to update
I did not know that weblate checks the build status
However - this being a feature, it would be nice to have a message when I pulled the repository here:

Saying: The source repository contains build errors. Translations are not used unless the build errors are removed.

Screenshots

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

• Do Translations work? niccokunzmann/open-web-calendar#458
• Search: https://docs.weblate.org/en/latest/search.html?q=failed+build&check_keywords=yes&area=default

[nijel]

How is the build related to Weblate? Weblate just follows whatever is in the repository, it is not connected to your CI.

[niccokunzmann]

Weblate just follows whatever is in the repository, it is not connected to your CI.

Hi, I agree that I understood that. And what seemed to happen is what I described.

How is the build related to Weblate?

I do not know. Maybe, there is something with the web hooks. They are set as shown in the documented pictures.
The build runs on every commit and Weblate is supposed to pull on every commit in the master branch, as configured in the GitHub Setup Section.

[nijel]

Sorry, but I have no clue what happens when "Make the build fail" and how that is supposed to be related to Weblate. Most likely, this is a duplicate of #12365 and not related to whatever happens inside your build.

[nijel]

Duplicate of #12365

[niccokunzmann]

Hm. I am not sure this is a duplicate of #12365. However, the timing of the fix roll-out could have matched exactly with me configuring the Weblate project: As soon as I corrected the build (green GitHub Actions), the string appeared in Weblate.

A testable "Make the build fail" would be the GitHub Action below.

name: "build"

on: [push, pull_request]

jobs:
  build:
    name: "build"
    runs-on: ubuntu-latest
    steps:
    - run: true # switch this to false to make the build fail

I also corrected the steps above.