Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make suggestions available in read-only mode #3785

Closed
Kyuuu opened this issue Apr 24, 2020 · 6 comments
Closed

Make suggestions available in read-only mode #3785

Kyuuu opened this issue Apr 24, 2020 · 6 comments
Labels
question This is more a question for the support than an issue. wontfix Nobody will work on this.

Comments

@Kyuuu
Copy link
Contributor

Kyuuu commented Apr 24, 2020

Is your feature request related to a problem? Please describe.
I use the read-only flag to block the possibility to change strings while I do not notice.
However, some translators reported that these strings have syntax errors not connected with terms I care about. It will be great for people with translate permissions to make suggestions in read-only mode also.

Describe the solution you'd like
Possibility for translators to suggest changes even with a read-only flag.

Whatever is admin should be able to accept these suggestions just like that or has to delete the read-only flag before.

Describe alternatives you've considered
(Yeah, I heard about proofreaders option? Or something. But I totally do not get how it works and permissions on the admin page are a bit complicated and there are too many of them that I do not use it at all. Just the option to make a normal suggestion with this flag would be perfect!).

Additional context
image


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@nijel nijel added the question This is more a question for the support than an issue. label Apr 24, 2020
@nijel
Copy link
Member

nijel commented Apr 24, 2020

Using review workflow seems better fit for your use case, see https://docs.weblate.org/en/latest/workflows.html#dedicated-reviewers

The read only strings are intended for string that are not supposed to be changed (some file formats support this natively, for other you can add flag in Weblate).

@Kyuuu
Copy link
Contributor Author

Kyuuu commented Apr 24, 2020

Hm. If I just left translation that I do not care about with "Waiting for review" option - would it work just like I even do not turn on review option?

Also, do I have to approve every string if I want it to be sent to the repository? Or "waiting for review" strings are just sent normally?

And is there a way to mark all languages as "Approved" in the selected string? Or do I have to open every single language and mark it separately?

@nijel
Copy link
Member

nijel commented Apr 24, 2020

Yes, for people with only translate permission it will behave exactly like now. With review permission, there will be additional state to select.

Currently, all strings are committed, this might be configurable in future, see #3745

You can use bulk edit to change state of more strings.

@Kyuuu
Copy link
Contributor Author

Kyuuu commented Apr 24, 2020

"You can use bulk edit to change state of more strings."

Hm, then I think that the "needs-approval" / "suggestions-only" flag would be great or another similar thing to mark all string's actual translations and these ones that will be added in the future as something that may be suggested only cause it is important to check.

@nijel
Copy link
Member

nijel commented Apr 24, 2020

I see no need for additional flag. In case you want to check the string before approval, flag them manually. If you want to freeze current state, use bulk edit with state:translated search and set all strings to approved.

@stale
Copy link

stale bot commented May 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Nobody will work on this. label May 6, 2020
@stale stale bot closed this as completed May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question This is more a question for the support than an issue. wontfix Nobody will work on this.
Projects
None yet
Development

No branches or pull requests

2 participants