Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any way to persist changes to files only after they have been approved? #6731

Closed
1 task done
chrisandrewcl opened this issue Oct 28, 2021 · 3 comments
Closed
1 task done
Labels
duplicate Similar issue or pull request already exists. question This is more a question for the support than an issue.

Comments

@chrisandrewcl
Copy link

chrisandrewcl commented Oct 28, 2021

I am using Weblate for a web project that uses monolingual JSON nestes structure files, and facing an issue with our workflow because unreviwed changes are being committed to our repository.

I would like that changes were persisted to files only after have being approved.

Is there currently any way for Weblate to support this workflow?

I tried enabling the review features, but it doesn't make sense for us, since our JSON files are being updated regardless of it (which, according to the docs, seems to be the intended behavior).

  • I've read and searched the docs and did not find the answer there.

To Reproduce the issue

Steps to reproduce the behavior:

  1. Translator submits a change to a string
  2. The string state will be "needs editing" or "waiting for review"
  3. The string will be persisted in the file and eventually committed

Expected behavior

  1. Translator submits a change to a string
  2. The string state will be "needs editing" or "waiting for review"
  3. The string is not persisted until a reviewer changes its state to "approved"

Screenshots

N/A

Exception traceback

N/A

Server configuration and status

Weblate installation: docker

Weblate deploy checks

N/A

Additional context

Weblate v4.8.1

@chrisandrewcl chrisandrewcl added the question This is more a question for the support than an issue. label Oct 28, 2021
@github-actions
Copy link

This issue looks more like a support question than an issue. We strive to answer these reasonably fast, but purchasing the support subscription is not only more responsible and faster for your business but also makes Weblate stronger.

In case your question is already answered, making a donation is the right way to say thank you!

@nijel nijel added the duplicate Similar issue or pull request already exists. label Oct 28, 2021
@nijel
Copy link
Member

nijel commented Oct 28, 2021

Duplicate of #3745

@nijel nijel marked this as a duplicate of #3745 Oct 28, 2021
@nijel nijel closed this as completed Oct 28, 2021
@github-actions
Copy link

The issue you have reported is now resolved. If you don’t feel it’s right, please follow its labels to get a clue for further steps.

  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Similar issue or pull request already exists. question This is more a question for the support than an issue.
Projects
None yet
Development

No branches or pull requests

2 participants