Enhance admin note visibility and improve accessibility for quick actions #5968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ader. - Added a visual indicator for admin notes to display when a note is present, without requiring the modal to be opened. - Standardized the size of all three admin quick action buttons for consistency. - Implemented screen reader messages to improve accessibility for the newly added features.
ragesoss
reviewed
Nov 14, 2024
|
|
||
| // Accessible message for screen readers, indicating whether there are new admin notes or none available | ||
| const notesAriaLabel = !notesList.length ? I18n.t('notes.admin.aria_label.no_notes_available') | ||
| : I18n.t('notes.admin.aria_label.new_notes_message', { count: notificationCount, plural: notificationCount > 1 ? 's' : '' }); |
There was a problem hiding this comment.
This is not a good way to handle plurals, as it will just add 's' no matter the language.
I suggest rewriting it to just take the count parameter, such as by using "note(s)" in the message.
Abishekcs
force-pushed
the
feature/admin-note-indicator
branch
from
91654f8
to
307b83f
Compare
Abishekcs
force-pushed
the
feature/admin-note-indicator
branch
from
307b83f
to
6e1ce57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5962
What this PR does
Screenshots ( visual indicator )
Before:
Before.1.mp4
After:
After.1.1.mp4
Screenshots ( quick action buttons)
Before:
After:
Screenshots (For Screen Reader)
1 - When No Notes are available
1.-.For.Screen.Reader.When.No.Notes.are.available.mp4
2 - When there are no newly created Notes
2.-.For.Screen.Reader.When.there.are.no.newly.created.Notes.mp4
3 - When newly created notes are available
3-.Screen.Reader.When.newly.created.notes.are.available.mp4
Open questions and concerns
I noticed there was an
empty status_panel.jsxfile in theadmin_notes folder. Since it was empty and there was no indication it was needed for future use, I deleted it. If it's required later, I can add it back.