Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Minimal diffs of comments and strings. #740

Open
Enoumy opened this issue Jul 23, 2024 · 0 comments
Open

[Feature Request] Minimal diffs of comments and strings. #740

Enoumy opened this issue Jul 23, 2024 · 0 comments

Comments

@Enoumy
Copy link

Enoumy commented Jul 23, 2024

Hi! I love difftastic!

I have a feature request that I would like to submit a pull request for, but I wanted to first check in if this is something that would be generally useful first!

I would like "minimal diffs of comments and strings". For instance, take the following diff:

image

difftastic will color the entire string red/green and will bold the parts that changed. My feature request is to only color the parts that changed as green or red:

image

I totally understand that there may be use cases/situations for where the entire string should be colored red/green and only the parts that actually changed should be bolded/styled differently (e.g. whitespace changes in a string), which is why I was thinking that this change in behavior could be gated/opted into with a flag.

Please let me know if this sounds reasonable to you and I can send over a PR your way for review. Also curious on your thoughts on this.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant