Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default use default system paths for SSL CA #320

Open
nmaludy opened this issue Dec 10, 2020 · 1 comment
Open

By default use default system paths for SSL CA #320

nmaludy opened this issue Dec 10, 2020 · 1 comment

Comments

@nmaludy
Copy link

nmaludy commented Dec 10, 2020

Currently SSL verification only works if you explicitly set the ca_trust_path on a connection. If i try to connect without setting it, i get an error that it can't establish SSH trust (with verification) even though the CA certificate is in my system's CA store (/etc/pki/tls/cert.pem).

If i explicitly set ca_trust_path: '/etc/pki/tls/cert.pem', then the connection works just fine with SSL verification enabled.

It looks like in order to support looking for CA certs in the default system paths, we would need to call

@httpcli.ssl_config.set_default_paths

Here, i think? https://github.com/WinRb/WinRM/blob/master/lib/winrm/http/transport.rb#L26

Reference: https://makandracards.com/makandra/50532-making-httpclient-use-the-operating-system-s-ssl-cert-store

If this sounds reasonable, i'll happily make a PR!

@mwrock
Copy link
Member

mwrock commented Dec 14, 2020

Yes that sounds good @nmaludy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants