Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging error object fails #46

Open
michaelw85 opened this issue May 28, 2020 · 3 comments
Open

Logging error object fails #46

michaelw85 opened this issue May 28, 2020 · 3 comments

Comments

@michaelw85
Copy link

michaelw85 commented May 28, 2020

TypeError: Cannot read property 'split' of undefined
    at graylog.log [as _log] (/Users/.....node_modules/graylog2/graylog.js:146:34)
    at graylog.error (/Users/.....node_modules/graylog2/graylog.js:93:17)

Graylog code:

    } else if (short_message.stack && short_message.message) {

        // Short message is an Error message, we process accordingly
        message.short_message = short_message.message;
        message.full_message  = short_message.stack;

        // extract error file and line
        fileinfo = message.stack.split('\n')[0];

Looking at this, the last line message.stack should be short_message.stack.
Message is a newly build object within the library which does not contain a stack trace by default.

@michaelw85
Copy link
Author

michaelw85 commented May 29, 2020

I see this is already fixed & merged (commit 82532a6) but not released yet. Could this be released @ronkorving 😄

@bendavis78
Copy link

I am also seeing this issue. Any reason this hasn't been released?

@mb-realpage
Copy link

+1 from me. A quick glance at the code immediately showed the problem. Is this project looking for a new owner?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants